Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
GitHub Actions is having issues again. https://www.githubstatus.com/ |
|
It passes now. |
|
I need more time to look at this properly, but it feels like a shame if we don't switch |
|
Good point about this not closing the linked issue. |
|
To clarify: If I find time to do more, I'd like to do it in a separate PR. And possibly work on |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good apart from one detail
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
Diff from mypy_primer, showing the effect of this PR on open source code: poetry (https://github.com/python-poetry/poetry.git)
- poetry/console/commands/self/update.py:234: error: Argument "fileobj" to "TarFile" has incompatible type "GzipFile"; expected "Optional[IO[bytes]]"
|
Literalformode.Iterable.collections.abc.IOinTarFile.More
IOimprovements are possible in the future:_ReadableFileobjand_WritableFileobj, depending onmode.TarFile.bz2open()and.xzopen()still useIO. This depends on improvingbz2.pyiandlzma.pyirespectively gaining protocols.TarFile.open()and module-levelopen()still useIO. This could be improved using overloads.IO.Closes: #5491