builtins.sum: Items in the iterable must support addition with int if no start value is given#8000
Merged
AlexWaygood merged 6 commits intopython:masterfrom Jun 13, 2022
Merged
Conversation
…t` value is given
AlexWaygood
commented
May 31, 2022
Comment on lines
+25
to
+27
| # TODO: these pass pyright with the current stubs, but mypy erroneously emits an error: | ||
| # sum([3, Fraction(7, 22), complex(8, 0), 9.83]) | ||
| # sum([3, Decimal('0.98')]) |
Member
Author
There was a problem hiding this comment.
mypy also emits an error for these tests on current master, so this PR wouldn't be introducing a regression here.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Any thoughts from anyone on whether this is a good idea? :) |
srittau
reviewed
Jun 8, 2022
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jun 13, 2022
Member
|
This just found a bug where we were doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7574 (cc. @jpy-git). I think this is just about the best we can do without introducing many false-positive errors.