Fix broken stubsabot logic in find_first_release_with_py_typed#9760
Merged
AlexWaygood merged 3 commits intomainfrom Feb 19, 2023
Merged
Fix broken stubsabot logic in find_first_release_with_py_typed#9760AlexWaygood merged 3 commits intomainfrom
find_first_release_with_py_typed#9760AlexWaygood merged 3 commits intomainfrom
Conversation
Akuli
reviewed
Feb 19, 2023
Akuli
approved these changes
Feb 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9759
I tested this locally: with this patch,
DateTimeRangeis correctly marked as obsolete if I run it locally. Without it, stubsabot just tries to bumpDateTimeRangeto the latest version, without noticing thatDateTimeRangeadded apy.typedfile in the latest version, released in the last 24 hours.