Made proposed change to the typing spec with regard to NoReturn and…#1570
Merged
JelleZijlstra merged 1 commit intopython:mainfrom Jan 12, 2024
Merged
Made proposed change to the typing spec with regard to NoReturn and…#1570JelleZijlstra merged 1 commit intopython:mainfrom
NoReturn and…#1570JelleZijlstra merged 1 commit intopython:mainfrom
Conversation
… where it can be used.
sobolevn
approved these changes
Jan 10, 2024
gvanrossum
approved these changes
Jan 10, 2024
JelleZijlstra
approved these changes
Jan 10, 2024
rchen152
approved these changes
Jan 10, 2024
hauntsaninja
approved these changes
Jan 12, 2024
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks! The phrasing might be read as implying some sort of stylistic preference, curious if that was intentional
Collaborator
Author
Not really. The intention was to try to give some background explanation for why there are two ways to spell the same type — and where each has typically been used. If you have a suggestion for how to improve the wording, let me know. |
Member
|
Merged as this has been approved by all Council members. I think the wording is fine, but we can tweak it in a follow-up PR if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… where it can be used.