Skip to content

chore: remove comments about phpcs #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rancoud merged 1 commit into from
Apr 24, 2025
Merged

chore: remove comments about phpcs #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@
/.gitattributes export-ignore
/.gitignore export-ignore
/.php-cs-fixer.php export-ignore
/phpcs.xml export-ignore
/phpunit.xml export-ignore
2 changes: 1 addition & 1 deletion .php-cs-fixer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
'no_empty_comment' => true,
'no_trailing_whitespace_in_comment' => true,
'single_line_comment_spacing' => true,
'single_line_comment_style' => ['comment_types' => ['asterisk', 'hash']]
'single_line_comment_style' => ['comment_types' => ['hash']]
];

$constantNotationRules = [
Expand Down
14 changes: 7 additions & 7 deletions tests/ApplicationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public function testGetInvalidFolder(): void
#[RunInSeparateProcess]
public function testConstructorEnvironment(): void
{
$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_empty.env')); // phpcs:ignore
$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_empty.env'));

static::assertInstanceOf(Application::class, $app);
}
Expand All @@ -187,7 +187,7 @@ public function testConstructorEnvironmentBadTimezone(): void
$this->expectException(ApplicationException::class);
$this->expectExceptionMessage('Invalid timezone: invalid. Check DateTimeZone::listIdentifiers()');

new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_bad_timezone.env')); // phpcs:ignore
new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_bad_timezone.env'));
}

/**
Expand All @@ -197,7 +197,7 @@ public function testConstructorEnvironmentBadTimezone(): void
#[RunInSeparateProcess]
public function testConstructorEnvironmentGoodTimezone(): void
{
$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_good_timezone.env')); // phpcs:ignore
$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_good_timezone.env'));

static::assertInstanceOf(Application::class, $app);
}
Expand All @@ -212,7 +212,7 @@ public function testConstructorEnvironmentInvalidRoutes(): void
$this->expectException(ApplicationException::class);
$this->expectExceptionMessage('Invalid routes');

new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_routes.env')); // phpcs:ignore
new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_routes.env'));
}

/**
Expand All @@ -225,7 +225,7 @@ public function testConstructorEnvironmentInvalidRoute(): void
$this->expectException(ApplicationException::class);
$this->expectExceptionMessage('Invalid route file');

new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_route.env')); // phpcs:ignore
new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_route.env'));
}

/**
Expand Down Expand Up @@ -289,7 +289,7 @@ public function testRunRouterException404Invalid(): void
$this->expectException(RouterException::class);
$this->expectExceptionMessage('The default404 is invalid');

$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env')); // phpcs:ignore
$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env'));
$request = $this->getRequest('GET', '/no_handle');
$app->run($request);
}
Expand All @@ -305,7 +305,7 @@ public function testRunRouterException(): void
$this->expectException(RouterException::class);
$this->expectExceptionMessage('The default404 is invalid');

$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env')); // phpcs:ignore
$app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env'));
$request = $this->getRequest('GET', '/no_handle');
$app->run($request);
}
Expand Down