Skip to content

fix: key type mismatch#691

Open
madocto wants to merge 4 commits intoreact-component:masterfrom
madocto:fix-key-type-mismatch
Open

fix: key type mismatch#691
madocto wants to merge 4 commits intoreact-component:masterfrom
madocto:fix-key-type-mismatch

Conversation

@madocto
Copy link
Copy Markdown
Contributor

@madocto madocto commented Mar 18, 2024

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.58%. Comparing base (4ae012f) to head (606fa0e).
⚠️ Report is 57 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          27       27           
  Lines         721      722    +1     
  Branches      196      198    +2     
=======================================
+ Hits          718      719    +1     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const { label, children, key, type, ...restProps } = opt as any;
const mergedKey = key ?? `tmp-${index}`;
// The type of `key` changes, `eventKey` is the original value
const mergeProps = { ...restProps, key: mergedKey, eventKey: mergedKey };
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...restProps 放后面比较匹配之前的效果

@MadCcc
Copy link
Copy Markdown
Member

MadCcc commented Mar 22, 2024

⚠️ 这个 PR 存在 breaking change 风险,如果用户 bug as feature 就会有问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants