Log on web module replacement instead of error#586
Merged
Conversation
rmorshea
force-pushed
the
better-modules
branch
from
88f0891 to
3bc38e7
Compare
Contributor
|
From a Django caching perspective, it would be ideal if it only replaced if the file contents are not identical. |
Collaborator
Author
|
That is what's implemented here. If the file contents differ and |
Archmonger
reviewed
Jan 15, 2022
rmorshea
force-pushed
the
better-modules
branch
2 times, most recently
from
054b5ca to
35a1b86
Compare
rmorshea
force-pushed
the
better-modules
branch
from
35a1b86 to
6100ed4
Compare
rmorshea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #584