feat: create rector to add names to boolean arguments#7944
Open
calebdw wants to merge 1 commit intorectorphp:mainfrom
Open
feat: create rector to add names to boolean arguments#7944calebdw wants to merge 1 commit intorectorphp:mainfrom
calebdw wants to merge 1 commit intorectorphp:mainfrom
Conversation
calebdw
force-pushed
the
calebdw/push-muvroqtpsztq
branch
2 times, most recently
from
165c5cd to
3a3f880
Compare
rules/CodeQuality/Rector/CallLike/NameBooleanOrNullArgumentRector.php
Outdated
Show resolved
Hide resolved
calebdw
force-pushed
the
calebdw/push-muvroqtpsztq
branch
from
3a3f880 to
c45162e
Compare
calebdw
changed the title
calebdw
force-pushed
the
calebdw/push-muvroqtpsztq
branch
from
c45162e to
d0eaef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Please see https://x.com/VotrubaT/status/2037867835469238412 for context.
This adds names to boolean call-site arguments---this increases code quality by making it clear what the value being passed is for:
Thanks!