Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes introduce a new section in the documentation explaining the retention behavior of Iceberg-enabled topics, clarifying that Iceberg table data is not subject to Redpanda topic retention policies and outlining the conditions under which Iceberg data is deleted. Additionally, a navigation label in the documentation index was updated to reflect expanded querying capabilities, now referencing both Snowflake and Open Catalog. Assessment against linked issues
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/manage/partials/iceberg/about-iceberg-topics.adoc (1)
225-232: Fix capitalization and grammar in the new retention section.
Change the heading to Title Case:
=== Iceberg Topic Retention.Adjust the sentence on line 227 for subject–verb agreement, e.g.:
Data in Iceberg-enabled topics remains queryable indefinitely. The generated Iceberg tables do not follow the configured retention policies for the Redpanda topic itself.or
Data in Iceberg-enabled topics remains queryable indefinitely. The generated Iceberg table data does not follow the configured retention policies for the Redpanda topic itself.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
modules/ROOT/nav.adoc(1 hunks)modules/manage/partials/iceberg/about-iceberg-topics.adoc(1 hunks)
🔇 Additional comments (1)
modules/ROOT/nav.adoc (1)
178-178: Navigation label updated to reflect broader catalog support.
The link text now includes "Open Catalog" to align with the expanded documentation on catalog integrations.
|
|
||
| === Iceberg topic retention | ||
|
|
||
| Data in Iceberg-enabled topics remains queryable as Iceberg tables indefinitely. The generated Iceberg table does not follow the configured retention policies for the Redpanda topic itself. The Iceberg table persists unless you: |
There was a problem hiding this comment.
Looking again, this kind of reads as though you can use Kafka to read Iceberg-enabled topics forever, which isn't true.
Maybe something like:
"Data in an Iceberg-enabled topic will be consumable from Kafka based on the configured Kafka retention policy. Conversely, data written to Iceberg will remain queryable as Iceberg tables indefinitely. The Iceberg table persists..."
kbatuigas
deleted the
DOC-1176-iceberg-support-retention-period-for-iceberg-data
branch
3 participants
Description
This pull request updates documentation for Iceberg-related features, including clarifying catalog usage and adding a new section on Iceberg topic retention. These changes improve the accuracy and comprehensiveness of the documentation.
Updates to Iceberg documentation:
modules/ROOT/nav.adocfor consistency with other catalog integration docs.modules/manage/partials/iceberg/about-iceberg-topics.adocexplaining the retention behavior of Iceberg-enabled topics. This includes details on how Iceberg tables persist beyond the configured retention policies of Redpanda topics and the conditions under which they can be deleted.Resolves https://redpandadata.atlassian.net/browse/
Review deadline:
Page previews
About Iceberg Topics > Enable Iceberg integration > Iceberg data retention
Checks