drop JSON cast cache in text-mode adapter#1182
Merged
Conversation
The JSON placeholder cast cache was keyed by rendered SQL text after schema template replacement. In setups that vary schema names heavily, that creates a monotonic key space and unbounded process-lifetime cache growth. Drop the cache and parse casts per call instead. Behavior stays the same, and this keeps the follow-up fix minimal while removing schema-driven growth.
brandur
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the JSON text-mode parameter adaptation work from #1155.
jsonPlaceholderCastscurrently caches parsed cast placeholders in aprocess-wide map keyed by the full rendered SQL string. Because adaptation runs
after template schema replacement, varying schemas produce distinct cache keys
for otherwise-identical queries. In long-lived processes with many schema
values, this can grow monotonically over time.
This change drops the cast-placeholder cache and parses casts per call instead,
which keeps behavior unchanged while removing schema-driven unbounded cache
growth risk.
Why this is safe
Testing
go test ./riverdriver/riverpgxv5 ./riverdriver/riverdrivertest