Skip to content

Aggregate fetchrequest does not apply predicate#16

Merged
roanutil merged 2 commits intomainfrom
aggregate-fetchrequest-does-not-apply-predicate
Jun 11, 2023
Merged

Aggregate fetchrequest does not apply predicate#16
roanutil merged 2 commits intomainfrom
aggregate-fetchrequest-does-not-apply-predicate

Conversation

@roanutil
Copy link
Copy Markdown
Owner

  • Set predicate for aggregate requests on fetchrequest
  • Add test cases to check that aggregate functions use their provided predicate

roanutil added 2 commits June 11, 2023 13:44
aggregate-fetchrequest-does-not-apply-predicate
…redicate

aggregate-fetchrequest-does-not-apply-predicate
@roanutil roanutil temporarily deployed to default June 11, 2023 18:57 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 18:57 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 18:57 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 18:57 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 18:57 — with GitHub Actions Inactive
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage: 95.34% and project coverage change: +0.27 🎉

Comparison is base (ef88b63) 85.17% compared to head (600dba8) 85.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   85.17%   85.45%   +0.27%     
==========================================
  Files          20       20              
  Lines        1545     1588      +43     
==========================================
+ Hits         1316     1357      +41     
- Misses        229      231       +2     
Impacted Files Coverage Δ
...DataRepositoryTests/AggregateRepositoryTests.swift 95.54% <95.23%> (-0.12%) ⬇️
...eDataRepository/CoreDataRepository+Aggregate.swift 91.07% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@roanutil roanutil merged commit 5b4681b into main Jun 11, 2023
@roanutil roanutil deleted the aggregate-fetchrequest-does-not-apply-predicate branch June 11, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants