Skip to content

Transaction author is not applied to the context for some functions#17

Merged
roanutil merged 3 commits intomainfrom
transaction-author-is-not-applied-to-the-context-for-some-functions
Jun 11, 2023
Merged

Transaction author is not applied to the context for some functions#17
roanutil merged 3 commits intomainfrom
transaction-author-is-not-applied-to-the-context-for-some-functions

Conversation

@roanutil
Copy link
Copy Markdown
Owner

  • Fix application of transactionAuthor to repository context in all editing functions
  • Update tests to verify transactionAuthor is present in history when used

roanutil added 3 commits June 11, 2023 14:51
…ting functions

transaction-author-is-not-applied-to-the-context-for-some-functions
transaction-author-is-not-applied-to-the-context-for-some-functions
…-not-applied-to-the-context-for-some-functions
@roanutil roanutil temporarily deployed to default June 11, 2023 19:53 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 19:53 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 19:53 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 19:53 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 11, 2023 19:53 — with GitHub Actions Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 11, 2023

Codecov Report

Patch coverage: 96.55% and project coverage change: +0.44 🎉

Comparison is base (5b4681b) 85.45% compared to head (60d25c9) 85.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   85.45%   85.89%   +0.44%     
==========================================
  Files          20       20              
  Lines        1588     1659      +71     
==========================================
+ Hits         1357     1425      +68     
- Misses        231      234       +3     
Impacted Files Coverage Δ
.../CoreDataRepository/CoreDataRepository+Batch.swift 84.21% <75.00%> (-1.25%) ⬇️
...s/CoreDataRepository/CoreDataRepository+CRUD.swift 92.30% <100.00%> (+0.48%) ⬆️
...CoreDataRepositoryTests/BatchRepositoryTests.swift 99.23% <100.00%> (+0.10%) ⬆️
.../CoreDataRepositoryTests/CRUDRepositoryTests.swift 93.00% <100.00%> (+0.39%) ⬆️
Tests/CoreDataRepositoryTests/CoreDataStack.swift 98.33% <100.00%> (+0.02%) ⬆️
...s/CoreDataRepositoryTests/CoreDataXCTestCase.swift 84.00% <100.00%> (+2.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@roanutil roanutil merged commit 9fa4ae4 into main Jun 11, 2023
@roanutil roanutil deleted the transaction-author-is-not-applied-to-the-context-for-some-functions branch June 11, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants