Skip to content

Accidental transaction author parameter on batch read#18

Merged
roanutil merged 4 commits intomainfrom
accidental-transaction-author-parameter-on-batch-read
Jun 12, 2023
Merged

Accidental transaction author parameter on batch read#18
roanutil merged 4 commits intomainfrom
accidental-transaction-author-parameter-on-batch-read

Conversation

@roanutil
Copy link
Copy Markdown
Owner

@roanutil roanutil commented Jun 12, 2023

  • Deprecate batch read with unused transactionAuthor. Add batch read with no transactionAuthor parameter.

…th no transactionAuthor parameter.

accidental-transaction-author-parameter-on-batch-read
@roanutil roanutil temporarily deployed to default June 12, 2023 05:29 — with GitHub Actions Inactive
@roanutil roanutil force-pushed the accidental-transaction-author-parameter-on-batch-read branch from 42c290a to 0f1dab4 Compare June 12, 2023 05:32
@roanutil roanutil temporarily deployed to default June 12, 2023 05:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 12, 2023 05:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 12, 2023 05:32 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 12, 2023 05:32 — with GitHub Actions Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20 🎉

Comparison is base (9fa4ae4) 85.89% compared to head (d201954) 86.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   85.89%   86.09%   +0.20%     
==========================================
  Files          20       20              
  Lines        1659     1683      +24     
==========================================
+ Hits         1425     1449      +24     
  Misses        234      234              
Impacted Files Coverage Δ
.../CoreDataRepository/CoreDataRepository+Batch.swift 84.48% <100.00%> (+0.27%) ⬆️
...CoreDataRepositoryTests/BatchRepositoryTests.swift 99.29% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

roanutil added 3 commits June 12, 2023 00:37
accidental-transaction-author-parameter-on-batch-read
accidental-transaction-author-parameter-on-batch-read
accidental-transaction-author-parameter-on-batch-read
@roanutil roanutil temporarily deployed to default June 12, 2023 05:38 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 12, 2023 05:38 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 12, 2023 05:38 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 12, 2023 05:38 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 12, 2023 05:38 — with GitHub Actions Inactive
@roanutil roanutil merged commit d4dc88e into main Jun 12, 2023
@roanutil roanutil deleted the accidental-transaction-author-parameter-on-batch-read branch June 12, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants