Skip to content

Feature/add unmanaged protocol for types that prefer a unique id other than object#30

Merged
r-jarvis merged 9 commits into3.0-previewfrom
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
Aug 26, 2024
Merged

Feature/add unmanaged protocol for types that prefer a unique id other than object#30
r-jarvis merged 9 commits into3.0-previewfrom
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID

Conversation

@roanutil
Copy link
Copy Markdown
Owner

Major refactor of the v3.0 preview code

feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 20, 2024

Codecov Report

❌ Patch coverage is 83.91864% with 925 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.32%. Comparing base (dc094d0) to head (f12cee7).
⚠️ Report is 50 commits behind head on 3.0-preview.

Files with missing lines Patch % Lines
.../Internal/ModelsWithIntId/ManagedIdModel_Int.swift 0.00% 110 Missing ⚠️
...ternal/ModelsWithIntId/ManagedIdUrlModel_Int.swift 0.00% 110 Missing ⚠️
...nternal/ModelsWithUuidId/UnmanagedModel_Uuid.swift 0.00% 88 Missing ⚠️
.../Internal/ModelsWithIntId/UnmanagedModel_Int.swift 0.00% 75 Missing ⚠️
...ternal/ModelsWithIntId/IdentifiableModel_Int.swift 0.00% 66 Missing ⚠️
.../Internal/ModelsWithIntId/FetchableModel_Int.swift 0.00% 61 Missing ⚠️
Sources/Internal/CoreDataStack.swift 48.00% 52 Missing ⚠️
...nternal/ModelsWithUuidId/ManagedIdModel_Uuid.swift 62.72% 41 Missing ⚠️
...s/CoreDataRepository/CoreDataRepository+Read.swift 81.00% 38 Missing ⚠️
...DataRepository/CoreDataRepository+Read_Batch.swift 72.16% 27 Missing ⚠️
... and 24 more
Additional details and impacted files
@@               Coverage Diff               @@
##           3.0-preview      #30      +/-   ##
===============================================
- Coverage        84.26%   82.32%   -1.94%     
===============================================
  Files               35       65      +30     
  Lines             2936     7311    +4375     
===============================================
+ Hits              2474     6019    +3545     
- Misses             462     1292     +830     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID
@r-jarvis r-jarvis merged commit 3afb4c3 into 3.0-preview Aug 26, 2024
@roanutil roanutil deleted the feature/add-unmanaged-protocol-for-types-that-prefer-a-unique-id-other-than-ObjectID branch August 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants