Skip to content

Bugfix/unable to build v2 with swift 6 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roanutil merged 4 commits into from
Dec 9, 2024
Merged

Bugfix/unable to build v2 with swift 6 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a377ab7
Relax RepositoryManagedModel.Unmanaged requirements to allow building…
roanutil Dec 5, 2024
79acecb
Update dependencies
roanutil Dec 5, 2024
5f05749
Run swiftformat
roanutil Dec 5, 2024
a022c86
Fix codecov in workflow
roanutil Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
run: swift test --enable-code-coverage
- name: Swift Coverage Report
run: xcrun llvm-cov export -format="lcov" .build/debug/CoreDataRepositoryPackageTests.xctest/Contents/MacOS/CoreDataRepositoryPackageTests -instr-profile .build/debug/codecov/default.profdata > coverage_report.lcov
- uses: codecov/codecov-action@v3
- uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true # optional (default = false)
8 changes: 4 additions & 4 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/CoreDataRepository+Aggregate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/CoreDataRepository+Batch.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/CoreDataRepository+CRUD.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/CoreDataRepository+Fetch.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CombineExt
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/CoreDataRepository.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/CoreDataRepositoryError.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Foundation

Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/FetchSubscription.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/NSManagedObject+CRUDHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData
import Foundation
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/NSManagedObjectContext+CRUDHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData
import Foundation
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/NSManagedObjectContext+Child.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData
import Foundation
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/NSManagedObjectContext+Scratchpad.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/ReadSubscription.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
4 changes: 2 additions & 2 deletions Sources/CoreDataRepository/RepositoryManagedModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData

/// A protocol for a CoreData NSManagedObject sub class that has a corresponding value type
public protocol RepositoryManagedModel: NSManagedObject {
associatedtype Unmanaged: UnmanagedModel where Unmanaged.RepoManaged == Self
associatedtype Unmanaged: UnmanagedModel
/// Returns a value type instance of `self`
var asUnmanaged: Unmanaged { get }
/// Create `self` from a corresponding instance of `UnmanagedModel`. Should not save the context.
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/Result+CRUDHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData
import Foundation
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/SubscriptionProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

public protocol SubscriptionProvider {
var id: AnyHashable { get }
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/UnmanagedModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData
import Foundation
Expand Down
2 changes: 1 addition & 1 deletion Sources/CoreDataRepository/_Result.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Foundation

Expand Down
2 changes: 1 addition & 1 deletion Tests/CoreDataRepositoryTests/AggregateRepositoryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Tests/CoreDataRepositoryTests/BatchRepositoryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Tests/CoreDataRepositoryTests/CRUDRepositoryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Tests/CoreDataRepositoryTests/CoreDataStack.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData

Expand Down
4 changes: 2 additions & 2 deletions Tests/CoreDataRepositoryTests/CoreDataXCTestCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down Expand Up @@ -93,7 +93,7 @@ class CoreDataXCTestCase: XCTestCase {
let historyResult = try XCTUnwrap(repositoryContext().execute(historyRequest) as? NSPersistentHistoryResult)
let history = try XCTUnwrap(historyResult.result as? [NSPersistentHistoryTransaction])
XCTAssertGreaterThan(history.count, 0)
history.forEach { historyTransaction in
for historyTransaction in history {
XCTAssertEqual(historyTransaction.author, transactionAuthor)
}
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/CoreDataRepositoryTests/FetchRepositoryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import Combine
import CoreData
Expand Down
2 changes: 1 addition & 1 deletion Tests/CoreDataRepositoryTests/Movie.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// MIT License
//
// Copyright © 2023 Andrew Roan
// Copyright © 2024 Andrew Roan

import CoreData
import CoreDataRepository
Expand Down