Fix parent context save bug. Change tests to use private context.#5
Merged
Fix parent context save bug. Change tests to use private context.#5
Conversation
roanutil
force-pushed
the
non-main-queue
branch
from
d82ce3a to
4e4ec41
Compare
- Fix `Result.save(context:)` to save parent context in `performAndWait` closure. - Change tests to use private context for repository - testFetchSubscription is failing because the private context is not updating when viewContext is changed.
non-main-queue
roanutil
force-pushed
the
non-main-queue
branch
from
4e4ec41 to
a5e4c3d
Compare
…ory context non-main-queue
non-main-queue
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 77.65% 77.50% -0.16%
==========================================
Files 11 11
Lines 555 560 +5
==========================================
+ Hits 431 434 +3
- Misses 124 126 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Owner
Author
|
I've tested this PR extensively on my local computer. However, the actions runner is having a problem with it. I've created an issue at: actions/runner-images#6098 (comment). I will work on getting a CI setup that works. For now, I think it's worth merging instead of waiting around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result.save(context:)to save parent context inperformAndWaitclosure.