Skip to content

Bugfix/create returns items with temporary objectids#9

Merged
roanutil merged 4 commits intomainfrom
bugfix/create-returns-items-with-temporary-objectids
Oct 28, 2022
Merged

Bugfix/create returns items with temporary objectids#9
roanutil merged 4 commits intomainfrom
bugfix/create-returns-items-with-temporary-objectids

Conversation

@roanutil
Copy link
Copy Markdown
Owner

  • Add save of repository's context after scratchpad save in mutating CRUD endpoints
  • Add call to scratchPad.obtainPermanentIDs in CRUD create before mapping to unmanaged.
  • Add CoreDataXCTestCase.verify helper to more thoroughly check the store for an object after creation or mutation.

…UD endpoints

bugfix/create-returns-items-with-temporary-objectids
…ping to unmanaged.

bugfix/create-returns-items-with-temporary-objectids
…tore for an object after creation or mutation.

bugfix/create-returns-items-with-temporary-objectids
@roanutil roanutil temporarily deployed to default October 28, 2022 04:02 Inactive
@roanutil roanutil temporarily deployed to default October 28, 2022 04:02 Inactive
@roanutil roanutil temporarily deployed to default October 28, 2022 04:02 Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 85.13% // Head: 85.09% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (5fde769) compared to base (c2a1f6f).
Patch coverage: 83.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   85.13%   85.09%   -0.05%     
==========================================
  Files          20       20              
  Lines        1487     1543      +56     
==========================================
+ Hits         1266     1313      +47     
- Misses        221      230       +9     
Impacted Files Coverage Δ
...s/CoreDataRepositoryTests/CoreDataXCTestCase.swift 81.25% <65.71%> (-8.41%) ⬇️
...s/CoreDataRepository/CoreDataRepository+CRUD.swift 91.81% <100.00%> (+0.81%) ⬆️
...CoreDataRepositoryTests/BatchRepositoryTests.swift 99.12% <100.00%> (+0.01%) ⬆️
.../CoreDataRepositoryTests/CRUDRepositoryTests.swift 92.60% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@roanutil roanutil merged commit 5298837 into main Oct 28, 2022
@roanutil roanutil deleted the bugfix/create-returns-items-with-temporary-objectids branch October 28, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when trying to update entity

2 participants