Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Fix problems shutting down nodes#296

Merged
jubeira merged 2 commits intorosjava:kineticfrom
rjcausarano:test-fix-proposal
Apr 5, 2019
Merged

Fix problems shutting down nodes#296
jubeira merged 2 commits intorosjava:kineticfrom
rjcausarano:test-fix-proposal

Conversation

@rjcausarano
Copy link
Contributor

Fixes failing ServiceIntegrationTests (issue #267) and also issue #241.

Copy link

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjcausarano, LGTM!

For the record, #242 fixed #241 but broke the tests described in #267.
This restores the tests in #267 while still addressing #241.

@jubeira jubeira merged commit 9a4116c into rosjava:kinetic Apr 5, 2019
@rjcausarano rjcausarano deleted the test-fix-proposal branch April 10, 2019 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants