Fix FileUtils.rm_rf to only mask exceptions about non existent files#5811
Closed
deivid-rodriguez wants to merge 1 commit intoruby:masterfrom
Closed
Fix FileUtils.rm_rf to only mask exceptions about non existent files#5811deivid-rodriguez wants to merge 1 commit intoruby:masterfrom
FileUtils.rm_rf to only mask exceptions about non existent files#5811deivid-rodriguez wants to merge 1 commit intoruby:masterfrom
Conversation
deivid-rodriguez
force-pushed
the
fix-fileutils-rm-rf
branch
2 times, most recently
from
a9171dc to
b3e0e73
Compare
deivid-rodriguez
force-pushed
the
fix-fileutils-rm-rf
branch
from
37411f4 to
0ecd047
Compare
deivid-rodriguez
force-pushed
the
fix-fileutils-rm-rf
branch
from
0ecd047 to
a35553f
Compare
Contributor
Author
|
I closed the upstream PR because I found a satisfactory workaround, so I'll close this one too. If I get any attention at either https://bugs.ruby-lang.org/issues/18784 or ruby/fileutils#57, I'll be happy to reopen the upstream PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a WIP PR to see how ruby/fileutils#58 plays with Ruby's CI.