fix: preserve respond_with_error payloads#40
Merged
Conversation
10e3ed3 to
e8107a6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes respond_with_error behavior so error payloads (e.g., hashes with custom code) and raised exceptions are preserved as-is when passed through to nats-pure, enabling non-500 error codes and in-place adjustments via blocks.
Changes:
- Stop coercing
respond_with_errorpayloads to strings; pass objects (including Exceptions and Hashes) through unchanged. - Forward blocks from
MessageWrapper#respond_with_errorto the underlying NATS message error response. - Add regression tests covering exception passthrough, hash failure passthrough, and block forwarding.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/leopard/message_wrapper.rb |
Removes string coercion and forwards optional blocks when responding with errors. |
lib/leopard/nats_api_server.rb |
Preserves raised exceptions by passing the exception object (not its message) to respond_with_error. |
test/lib/message_wrapper.rb |
Adds/updates tests to assert exceptions/hashes are passed through and blocks are forwarded. |
test/lib/nats_api_server.rb |
Updates handler-raise test to assert exception object passthrough and adds hash-failure regression coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kthibodeaux
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
respond_with_errorpayloads to strings before handing them tonats-pure{ code: 422, ... }payloads can be adjusted in placeTesting
Closes #39