xml cannot be empty while reading#183
Merged
DeepDiver1975 merged 1 commit intosabre-io:masterfrom Apr 15, 2020
Merged
Conversation
Contributor
Author
|
@DeepDiver1975 could you have a look? |
f1bb698 to
f03e438
Compare
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
============================================
+ Coverage 93.38% 97.61% +4.22%
Complexity 112 112
============================================
Files 15 13 -2
Lines 484 461 -23
============================================
- Hits 452 450 -2
+ Misses 32 11 -21
Continue to review full report at Codecov.
|
DeepDiver1975
approved these changes
Apr 15, 2020
Closed
This was referenced Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #166 is incomplete. It still allows this situation to happen in an infinite loop:
With this MR, now I see exception properly handled: