Skip to content

feat: update Node.js version and dependencies, use rolldown, enhance configurations, fix lint issues#28

Merged
mumenthalers merged 1 commit intomasterfrom
#27-update-libs-and-node
Mar 17, 2026
Merged

feat: update Node.js version and dependencies, use rolldown, enhance configurations, fix lint issues#28
mumenthalers merged 1 commit intomasterfrom
#27-update-libs-and-node

Conversation

@mumenthalers
Copy link
Contributor

No description provided.

@mumenthalers mumenthalers force-pushed the #27-update-libs-and-node branch 2 times, most recently from 9fa26cb to cf0b101 Compare March 17, 2026 07:53
@mumenthalers mumenthalers requested a review from Copilot March 17, 2026 12:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the action’s toolchain by bumping the Node.js baseline to v24, migrating the build output from ncc to rolldown, and introducing updated formatting/linting/commit tooling aligned with newer ESLint + TypeScript conventions.

Changes:

  • Update runtime/tooling to Node.js 24 (engines, action runtime, CI workflow, TS target).
  • Replace ncc build with rolldown and add/refresh repo-wide Prettier, ESLint (flat config), lint-staged, and commitlint configs.
  • Fix lint/type issues by tightening TS annotations and adjusting execution style (top-level await).

Reviewed changes

Copilot reviewed 18 out of 21 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tsconfig.json Updates TS target to ES2024 and normalizes exclude formatting.
src/lab.ts Adds top-level await and tightens typing for URL param / Octokit response.
src/index.ts Adds top-level await, adds lint suppression for GitHub payload access, tightens fetch param types.
prettier.config.js Introduces JS-based (ESM) Prettier configuration.
package.json Updates Node engine, deps, and switches build script to rolldown; adds CI format/lint scripts.
lint-staged.config.js Adds lint-staged configuration for formatting/linting staged files.
eslint.config.js Migrates to ESLint flat config with type-aware TypeScript rules.
commitlint.config.js Adds commitlint JS config.
action.yml Bumps action runtime to node24.
README.md Reformats workflow/docs content and updates development section formatting.
.prettierrc.yml Removes legacy Prettier YAML config in favor of JS config.
.prettierignore Ignores dist for formatting.
.nvmrc Updates local Node version to 24.
.npmrc Disables funding prompts.
.lintstagedrc.yml Removes legacy lint-staged YAML config in favor of JS config.
.husky/pre-commit Converts pre-commit hook to multi-line script and keeps building dist.
.github/workflows/test.yml Updates CI to use .nvmrc, adds formatting and linting checks, pins actions by SHA.
.eslintrc.yml Removes legacy ESLint YAML config in favor of flat config.
.commitlintrc.yml Removes legacy commitlint YAML config in favor of JS config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mumenthalers mumenthalers force-pushed the #27-update-libs-and-node branch from cf0b101 to e6df3ba Compare March 17, 2026 16:08
@mumenthalers mumenthalers merged commit 9d4a90c into master Mar 17, 2026
1 check passed
@mumenthalers mumenthalers deleted the #27-update-libs-and-node branch March 17, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants