[core] add Heartbeat-Interval value in send_heartbeat#3003
Open
ticpu wants to merge 1 commit intosignalwire:masterfrom
Open
[core] add Heartbeat-Interval value in send_heartbeat#3003ticpu wants to merge 1 commit intosignalwire:masterfrom
ticpu wants to merge 1 commit intosignalwire:masterfrom
Conversation
ticpu
added a commit
to ticpu/freeswitch-esl-tokio
that referenced
this pull request
Apr 10, 2026
EventHeader::HeartbeatInterval was added in commit 8859cb1 based on a local CAUCA fork that emits the header in send_heartbeat(). The matching upstream change is open as signalwire/freeswitch#3003 but not yet merged into signalwire/master. The enum-sync hook downloads C source from signalwire/master, finds the header in the Rust enum but not in send_heartbeat(), and exits non-zero. CI then sets C_SOURCE_AVAILABLE=false and skips badge updates. Add a pending-upstream allowlist that injects Heartbeat-Interval into the reference pool, so it traces to a known PR rather than appearing as an untraced extra. Remove the entry once #3003 merges. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Heartbeat-Intervalheader to theHEARTBEATevent fired bysend_heartbeat(), exposingruntime.event_heartbeat_interval(the value configured viaevent-heartbeat-intervalinswitch.conf) directly in the event.This makes heartbeat-driven liveness detection self-describing: a consumer receiving the event knows exactly how long to wait before considering FreeSWITCH unresponsive, without having to read the config separately or hard-code the 20-second default.
Already in production use on our side and consumed by
freeswitch-esl-tokioas a liveness signal — see theHeartbeatIntervalheader definition and the liveness detection rationale.