Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix IPython crash caused by pybind11 C++ object exposure and unsafe NumPy views in
plqERM_Ridge.fit().When running in IPython,
clf.fit(...)implicitly returnsself, which triggers sklearn’s_repr_mimebundle_. This introspects estimator attributes and attempts to accessself.opt_result_, a pybind11-wrapped C++ object (rehline_result) without a proper__repr__, causing crashes.Additionally, attributes such as
coef_,_Lambda,_Gamma, and_xiwere NumPy views into Eigen memory owned by the C++ object, creating potential dangling reference issues.Fix
self.opt_result_).copy()to ensure safe ownershipChanges
self.coef_ = result.beta.copy()self._Lambda = result.Lambda.copy()self._Gamma = result.Gamma.copy()self._xi = result.xi.copy()self.n_iter_ = result.niterself.dual_obj_ = list(result.dual_objfns)self.primal_obj_ = list(result.primal_objfns)self.opt_result_ = resultImpact
Related Issue
Closes #39
Type of Change
Checklist
pytest tests/ -vAdditional Notes
Workaround prior to this fix: