Skip to content

[Fix] - Leverage Jest fake timers to fix flaky tests#13

Merged
iBotPeaches merged 4 commits intomasterfrom
flaky-tests
Dec 13, 2022
Merged

[Fix] - Leverage Jest fake timers to fix flaky tests#13
iBotPeaches merged 4 commits intomasterfrom
flaky-tests

Conversation

@ian-wd
Copy link
Copy Markdown

@ian-wd ian-wd commented Dec 12, 2022

No description provided.

@ian-wd ian-wd requested review from iBotPeaches and old December 12, 2022 08:54
Copy link
Copy Markdown
Member

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the tests that do like

    if (process.env.CI === true) {
      return true;
    }

Are those now passable with these fake timers?

@ian-wd
Copy link
Copy Markdown
Author

ian-wd commented Dec 13, 2022

With all the tests that do like

    if (process.env.CI === true) {
      return true;
    }

Are those now passable with these fake timers?

yep they should pass now

@iBotPeaches
Copy link
Copy Markdown
Member

yep they should pass now

Can we remove those if checks so no more special treatment for ci?

@iBotPeaches iBotPeaches merged commit c893c37 into master Dec 13, 2022
@iBotPeaches iBotPeaches deleted the flaky-tests branch December 13, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants