Skip to content

ROX-32922: Add multi arch builds for main branch#92

Open
mtodor wants to merge 2 commits intomainfrom
mtodor/ROX-32922-add-multi-arch-builds
Open

ROX-32922: Add multi arch builds for main branch#92
mtodor wants to merge 2 commits intomainfrom
mtodor/ROX-32922-add-multi-arch-builds

Conversation

@mtodor
Copy link
Collaborator

@mtodor mtodor commented Mar 25, 2026

Description

Add multi-arch Konflux pipeline

This PR introduces a shared basic-component-pipeline.yaml and migrates both PipelineRun files to reference it instead of embedding the pipeline inline.

The previous setup built single-arch (amd64) images only. This change enables multi-arch release images from the push pipeline while keeping PR builds fast with amd64-only builds.

Changes

  1. New file: .tekton/basic-component-pipeline.yaml
  • A reusable kind: Pipeline resource using buildah-remote-oci-ta with a platform matrix, replacing the previous single-arch buildah-oci-ta.
  1. .tekton/acs-mcp-server-push.yaml:
  • Replaced ~580-line inline pipelineSpec with pipelineRef: basic-component-pipeline
  • Builds for all 4 platforms: amd64, arm64, ppc64le, s390x
  • Added hermetic: false (will be changed to true in future PRs), build-source-image: true, image-expires-after: 13w (similar config to stackrox), build-image-index: true
  1. .tekton/acs-mcp-server-pull-request.yaml**
  • Same inline → pipelineRef migration
  • Builds amd64 only (faster PR feedback)
  • Keep images expire after 5d
  • The on-pr- image tag prefix is removed. (not so important)

Review hint

Changes are minimal to keep review easier. If it's hard to review in GitHub, one way is to copy basic-component-pipeline.yaml content and compare with old acs-mcp-server-push.yaml and acs-mcp-server-pull-request.yaml.

Validation

  • Let Konflux CI run in PR and after merge

@mtodor mtodor requested a review from janisz as a code owner March 25, 2026 16:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.88%. Comparing base (0d685e2) to head (3ae66c7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files          30       30           
  Lines        1302     1302           
=======================================
  Hits          962      962           
  Misses        300      300           
  Partials       40       40           
Flag Coverage Δ
integration 73.88% <ø> (ø)
unit 73.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Mar 25, 2026

E2E Test Results

Commit: 3ae66c7
Workflow Run: View Details
Artifacts: Download test results & logs

=== Evaluation Summary ===

  ✓ list-clusters (assertions: 3/3)
  ✓ cve-detected-workloads (assertions: 3/3)
  ✓ cve-detected-clusters (assertions: 3/3)
  ~ cve-nonexistent (assertions: 2/3)
      - MaxToolCalls: Too many tool calls: expected <= 5, got 7
  ✓ cve-cluster-does-exist (assertions: 3/3)
  ~ cve-cluster-does-not-exist (assertions: 2/3)
      - ToolsUsed: Required tool not called: server=stackrox-mcp, tool=, pattern=list_clusters
  ✓ cve-clusters-general (assertions: 3/3)
  ✓ cve-cluster-list (assertions: 3/3)
  ✓ cve-log4shell (assertions: 3/3)
  ✓ cve-multiple (assertions: 3/3)
  ✓ rhsa-not-supported (assertions: 2/2)

Tasks:      11/11 passed (100.00%)
Assertions: 30/32 passed (93.75%)
Tokens:     ~54448 (estimate - excludes system prompt & cache)
MCP schemas: ~12738 (included in token total)
Agent used tokens:
  Input:  11083 tokens
  Output: 20581 tokens
Judge used tokens:
  Input:  62647 tokens
  Output: 50470 tokens

@mtodor mtodor force-pushed the mtodor/ROX-32922-add-multi-arch-builds branch from 6564f23 to d081119 Compare March 26, 2026 11:38
@mtodor mtodor force-pushed the mtodor/ROX-32922-add-multi-arch-builds branch from d081119 to 3ae66c7 Compare March 26, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants