ROX-23573: Violation 'Image tag' criteria should include image digest when tag is empty

[charmik-redhat]

Description

Updates violation message for 'Image tag' criteria to be more clear and include image digest when the tag is empty.

User-facing documentation

• CHANGELOG update is not needed
• documentation is not needed

Testing and quality

• the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
• CI results are inspected

Automated testing

• added unit tests
• added e2e tests
• added regression tests
• added compatibility tests
• modified existing tests

How I validated my change

Manual test

Violation message from a test cluster

Container 'vbar-control-agent' has image with an empty tag, digest sha256:631a35b6cc0638b3eed328ccea240199043dcfe4bed69c7cfc3d98752faa23fb 

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rhacs-bot]

Images are ready for the commit at 31e277b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-444-g31e277b3ea.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.36%. Comparing base (1ce0e17) to head (31e277b).
⚠️ Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
...oleanpolicy/violationmessages/printer/container.go	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #19623      +/-   ##
==========================================
+ Coverage   49.28%   49.36%   +0.08%     
==========================================
  Files        2735     2742       +7     
  Lines      206215   206935     +720     
==========================================
+ Hits       101633   102158     +525     
- Misses      97041    97190     +149     
- Partials     7541     7587      +46     

Flag	Coverage Δ
go-unit-tests	49.36% <0.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.