Eliminate redundant data processing in mcmc_areas_data()#501
Open
utkarshpawade wants to merge 4 commits intostan-dev:masterfrom
Open
Eliminate redundant data processing in mcmc_areas_data()#501utkarshpawade wants to merge 4 commits intostan-dev:masterfrom
utkarshpawade wants to merge 4 commits intostan-dev:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
=======================================
Coverage 98.66% 98.67%
=======================================
Files 35 35
Lines 5864 5865 +1
=======================================
+ Hits 5786 5787 +1
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
I don't see |
jgabry
requested changes
Mar 23, 2026
Member
jgabry
left a comment
jgabry
left a comment
There was a problem hiding this comment.
Thanks! Looks good, just one minor change
R/mcmc-intervals.R
Outdated
| } | ||
|
|
||
| # Internal helper shared by mcmc_intervals_data() and mcmc_areas_data() | ||
| compute_intervals <- function(data_long, prob, prob_outer, |
Member
There was a problem hiding this comment.
Can you move this internal helper function to the bottom of the file where the other internal functions are?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
Summary
prepare_mcmc_array(),merge_chains(), andmelt_mcmc()once at the top ofmcmc_areas_data()data_longintomcmc_intervals_data()via an internal.data_longparameter