Support for UQ and NICF with vectorized (SIMD) centered schemes#1149
Merged
pcarruscag merged 14 commits intodevelopfrom Jan 13, 2021
Merged
Support for UQ and NICF with vectorized (SIMD) centered schemes#1149pcarruscag merged 14 commits intodevelopfrom
pcarruscag merged 14 commits intodevelopfrom
Conversation
pcarruscag
commented
Jan 4, 2021
| * \param[in] n: order of matrix V | ||
| */ | ||
| template<class Mat, class Vec, class W> | ||
| static void tred2(Mat& V, Vec& d, W& e, int n) { |
Member
Author
There was a problem hiding this comment.
@jayantmukho do you know any simple methods that would be stable enough on 3x3 problems to do what tred2 / tql2 do?
That is the only thing standing in the way of vectorizing the UQ stuff (too many if's in these routines).
Member
Author
|
I was told last week that the numerics used for boundary terms pretty much never changed in 9 years. |
Contributor
|
Valgrind indicated a memory leak associated to |
Member
Author
|
Absolutely I'll have a look |
Member
Author
|
Fixed in #1159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This allows UQ and NICF features to be used with the vectorized centered schemes.
UQ can also be used with the vectorized Roe scheme, but not NICF as that would not be equivalent to the general Roe implementation.
With this the older implementations were removed as they are never used as boundary numerics.
Related Work
#1022
PR Checklist