Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions. |
|
WIP to improve adjoint accuracy for large displacements |
| Donor_Variable[iVar] = DisplacementDonor[iVar]; | ||
|
|
||
| if (struct_config->GetTime_Domain()) { | ||
| if (struct_config->GetTime_Domain() && !struct_config->GetWrt_Slice()) { |
There was a problem hiding this comment.
I clicked (kindof) randomly on this commit and saw this WRT_SLICE option which was just deprecated in #1129 ... oh and I just also just saw that you hooked it because it is otherwise unused :D I already wondered why it would mater here ... So I guess you have to go for another one if you merge develop, sorry
I am guilty of doing that as well ;)
There was a problem hiding this comment.
That's no problem at all. I just wanted to test the new velocity interface without having to recompile every time when I didn't know whether this interface would be adopted or not in the end. But this has been validated now and so I'll set up proper options when I move forward with this PR...
|
This PR has changes to the primal dynamic FSI as well as the adjoints. Also, some of the changes made for the FSI adjoints no longer seem to be necessary. I'm going to close this PR and open two separate ones for the primal and adjoint with only the necessary changes. |
3 participants
Proposed Changes
WIP of the extension of FSI discrete adjoint to time-domain.
This originally started with the legacy FSI drivers but is being migrated to the new multizone drivers in this draft.
Related Work
@oleburghardt mentioned unsteady adjoints to follow PR #854 for CHT which will be closely related to this
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.