Be stricter in index routes verifications#924
Merged
Eijebong merged 1 commit intotaskcluster:mainfrom Mar 24, 2026
Merged
Conversation
jcristau
approved these changes
Mar 24, 2026
Some verification was added in taskcluster#722 but for slashes only. Taskcluster is actually way stricter than that with what it accepts as index keys and it doesn't prevent task creations when index routes are invalid (taskcluster/taskcluster#6266). The regex comes from the service iteself at https://github.com/taskcluster/taskcluster/blob/62655d84d55680ffb8faa35e7deadee69f389efa/services/index/src/helpers.js#L8 Fixes taskcluster#883
Eijebong
force-pushed
the
better-routes-validation
branch
from
3f0ec6e to
1e06e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some verification was added in #722 but for slashes only. Taskcluster is actually way stricter than that with what it accepts as index keys and it doesn't prevent task creations when index routes are invalid (taskcluster/taskcluster#6266).
The regex comes from the service iteself at
https://github.com/taskcluster/taskcluster/blob/62655d84d55680ffb8faa35e7deadee69f389efa/services/index/src/helpers.js#L8
Fixes #883