add CBCentralManager.RetrievePeripherals#55
Merged
Conversation
added 9 commits
October 26, 2023 23:14
## RetrievePeripheralsWithIdentifiersにしない理由 xamarinではWithIdentifiersが付いているが、引数にserviceUUIDsを入れると書きつつ変数がperipheralUuid等おかしいため同じにしない。 https://learn.microsoft.com/en-us/dotnet/api/corebluetooth.cbcentralmanager.retrieveperipheralswithidentifiers?view=xamarin-ios-sdk-12 引数名がIDならWithIdentifiersいらないと判断した。 ## 古いPeripheralのDisposeについて 再取得するなら、以前の情報は不要なはずなため破棄している。 が、これに関してはそもそもperipheralを辞書で保持すること自体がオリジナルとずれていてあまり良くないのかなと感じている。 そのため将来的にはこの処理はけすかもしれない
過去の情報を用意することは難しいため、動くことだけを確認
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
過去に接続したことのあるPeripheralを取得するためのRetrievePeripheralsを追加
Test
テストコードを書いて、UUIDを差し替えて取得できることを確認