Skip to content

remove throw on callback #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teach310 merged 1 commit into from
Oct 30, 2023
Merged

remove throw on callback #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions Packages/com.teach310.core-bluetooth-for-unity/Runtime/SafeNativePeripheralHandle.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,6 @@ static INativePeripheralDelegate GetDelegate(IntPtr peripheralPtr)
internal static void DidDiscoverServices(IntPtr peripheralPtr, IntPtr commaSeparatedServiceUUIDsPtr, int errorCode)
{
string commaSeparatedServiceUUIDs = Marshal.PtrToStringUTF8(commaSeparatedServiceUUIDsPtr);
if (string.IsNullOrEmpty(commaSeparatedServiceUUIDs))
{
throw new ArgumentException("commaSeparatedServiceUUIDs is null or empty.");
}

GetDelegate(peripheralPtr)?.DidDiscoverServices(
commaSeparatedServiceUUIDs.Split(','),
CBError.CreateOrNullFromCode(errorCode)
Expand All @@ -84,11 +79,6 @@ internal static void DidDiscoverServices(IntPtr peripheralPtr, IntPtr commaSepar
internal static void DidDiscoverCharacteristics(IntPtr peripheralPtr, IntPtr serviceUUIDPtr, IntPtr commaSeparatedCharacteristicUUIDsPtr, int errorCode)
{
string commaSeparatedCharacteristicUUIDs = Marshal.PtrToStringUTF8(commaSeparatedCharacteristicUUIDsPtr);
if (string.IsNullOrEmpty(commaSeparatedCharacteristicUUIDs))
{
throw new ArgumentException("commaSeparatedCharacteristicUUIDs is null or empty.");
}

GetDelegate(peripheralPtr)?.DidDiscoverCharacteristics(
Marshal.PtrToStringUTF8(serviceUUIDPtr),
commaSeparatedCharacteristicUUIDs.Split(','),
Expand Down Expand Up @@ -156,11 +146,6 @@ internal static void DidUpdateName(IntPtr peripheralPtr)
internal static void DidModifyServices(IntPtr peripheralPtr, IntPtr commaSeparatedServiceUUIDsPtr)
{
string commaSeparatedServiceUUIDs = Marshal.PtrToStringUTF8(commaSeparatedServiceUUIDsPtr);
if (string.IsNullOrEmpty(commaSeparatedServiceUUIDs))
{
throw new ArgumentException("commaSeparatedServiceUUIDs is null or empty.");
}

GetDelegate(peripheralPtr)?.DidModifyServices(
commaSeparatedServiceUUIDs.Split(',')
);
Expand Down