refactor: move AOT Callback from SafeHandle to Proxy#67
Merged
Conversation
added 3 commits
November 2, 2023 22:57
理由は2つ。 1. SafeHandleの役割を安全な解放という1つに止めるため。 2. AOT.MonoPInvokeCallbackへの依存をSafeHandleから外すため。 後者はDocFxで生成するときにSafeHandleを参照するときにUnityEngineを参照しないようにするために必要
teach310
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AOT.MonoPInvokeCallbackの定義場所を変更
理由は2つ。
後者はDocFxで生成するときにSafeHandleを参照するときにUnityEngineを参照しないようにするために必要