add NativeCallbacks Class to avoid depending on UnityEngine#68
Merged
add NativeCallbacks Class to avoid depending on UnityEngine#68
Conversation
added 5 commits
November 4, 2023 22:03
## なぜこのクラスを作る必要があったのか NativeCentralManagerProxyがAOT.MonoPInvokeCallbackを参照しないようにするため。 これを参照してしまうと、DocFXを使う際にUnityEngineを参照してしまう
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
DocFXでドキュメントを生成する際に対象のスクリプトがUnityEngineへの参照を含んでいる場合には
Unityがプリコンパイルしたdllを取得できないとエラーになる。
従ってGitHub Action上でUnityEngineに依存せずにドキュメントを生成するためにはUnityEngineの参照を消したい。
そして
AOT.MonoPInvokeCallbackはUnityEngineに依存している。(using UnityEngineがなくても)Description
using UnityEngineを削除これによってNativeXXCallbacksと依存性注入する役割のInitializerを除けばUnityEngineに依存しなくなる。
クラス名について
NativeXXHandlersやNativeXXEventHandlersも候補だった。
が、イベントハンドラよりはCallbacksのほうがイメージに近かったためこちらを選択。
ただし、メソッド名が「RegisterHandlers」なためそこの不一致があまり気持ちよくない。
優先度は低いため保留する。
Test
自動テストが動くことを確認したのみ