Add MariaDB container implementation under org.testcontainers.mariadb#11083
Merged
eddumelendez merged 1 commit intomainfrom Oct 9, 2025
Merged
Add MariaDB container implementation under org.testcontainers.mariadb#11083eddumelendez merged 1 commit intomainfrom
eddumelendez merged 1 commit intomainfrom
Conversation
PreAgile
added a commit
to PreAgile/testcontainers-java
that referenced
this pull request
Mar 22, 2026
…bers MariaDBContainer.getLivenessCheckPortNumbers() returned the hardcoded internal port (3306) instead of the mapped external port. This was originally fixed for other containers in PR testcontainers#5734 but MariaDB was missed. The new MariaDBContainer class (PR testcontainers#11083) then copied the same buggy implementation. Delegate to super.getLivenessCheckPortNumbers() which correctly maps internal ports to external mapped ports via getMappedPort(). Applied to both: - org.testcontainers.mariadb.MariaDBContainer (current) - org.testcontainers.containers.MariaDBContainer (deprecated) Fixes testcontainers#10359
PreAgile
added a commit
to PreAgile/testcontainers-java
that referenced
this pull request
Mar 22, 2026
…bers MariaDBContainer.getLivenessCheckPortNumbers() returned the hardcoded internal port (3306) instead of the mapped external port. This was originally fixed for other containers in PR testcontainers#5734 but MariaDB was missed. The new MariaDBContainer class (PR testcontainers#11083) then copied the same buggy implementation. Delegate to super.getLivenessCheckPortNumbers() which correctly maps internal ports to external mapped ports via getMappedPort(). Applied to both: - org.testcontainers.mariadb.MariaDBContainer (current) - org.testcontainers.containers.MariaDBContainer (deprecated) Fixes testcontainers#10359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.