Add JDBC custom credential support for postgres#1293
Merged
rnorth merged 4 commits intotestcontainers:masterfrom Mar 17, 2019
Merged
Add JDBC custom credential support for postgres#1293rnorth merged 4 commits intotestcontainers:masterfrom
rnorth merged 4 commits intotestcontainers:masterfrom
Conversation
rnorth
requested changes
Mar 7, 2019
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
I only have some trivial style suggestions, but otherwise this is great. Thank you very much!
modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java
Outdated
Show resolved
Hide resolved
| String resultUser = rs.getString(1); | ||
| assertEquals("User from query param is created.", "someuser@%", resultUser); | ||
| // Not all databases (eg. Postgres) return @% at the end of user name. We just need to make sure the user name matches. | ||
| if(resultUser.endsWith("@%")) resultUser = resultUser.substring(0, resultUser.length() - 2); |
Member
There was a problem hiding this comment.
Suggested change
| if(resultUser.endsWith("@%")) resultUser = resultUser.substring(0, resultUser.length() - 2); | |
| if (resultUser.endsWith("@%")) { | |
| resultUser = resultUser.substring(0, resultUser.length() - 2); | |
| } |
Just a small style change.
modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java
Show resolved
Hide resolved
rnorth
requested changes
Mar 7, 2019
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
I only have some trivial style suggestions, but otherwise this is great. Thank you very much!
Contributor
Author
|
Thanks for the review @rnorth . I have formatted the code in the latest commit. Please check when you get a chance. |
rnorth
approved these changes
Mar 17, 2019
Member
|
Thanks @manikmagar! |
Member
|
Releasing this in 1.11.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds custom username and password support for Postgres. It refactors the function in MySQL and MariaDB drivers to reuse. This is based on #617 .