feat(courses): integrate course API with offline-first pagination#42
feat(courses): integrate course API with offline-first pagination#42Gowreesh-A-M wants to merge 2 commits intoref/lesson-detailfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the Study tab by integrating a real course API, moving away from static mock data. It establishes a robust offline-first architecture with efficient pagination, ensuring a smooth user experience even with large datasets or intermittent connectivity. The changes include a new centralized networking layer, refined loading state management, and an updated data model to support richer course information. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the Study tab to integrate a real backend API for course data, transitioning from static mock data to an offline-first, paginated approach. Key changes include the introduction of ApiClient and ApiException for centralized HTTP communication with JWT authentication, and an updated HttpDataSource that fetches paginated course data. The data layer is enhanced with a new PaginatedResponseDto model and the CourseDto and local Drift database (CoursesTable) now support an image field, with the database schema version incremented. The CourseRepository is refactored to manage pagination state and supports incremental fetching, persisting data locally, and providing sync state callbacks. The StudyScreen is updated to use a CustomScrollView with a ScrollController for infinite scrolling, displaying appropriate loading indicators for initial fetches and pagination. Course cards are also enhanced to display fetched course images, with a fallback to a default icon. The application configuration now defaults to using the real HTTP data source.
e4558a7 to
0ef834d
Compare
f0b161c to
aa1252c
Compare
aa1252c to
34d015d
Compare
Uh oh!
There was an error while loading. Please reload this page.