feat(courses): implement api-direct server-side search#46
feat(courses): implement api-direct server-side search#46Gowreesh-A-M wants to merge 4 commits intofeat/course-card-total-contentsfrom
Conversation
Gowreesh-A-M
commented
Mar 24, 2026
- Transition from local filtering to direct server-side search for comprehensive results
- Separate search results from the main list to keep the experience clean
- Add protection against accidental duplicate requests when scrolling or typing fast
- Optimize the study screen search to properly handle search clearing and new queries
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the course search experience by moving the search logic to the server-side. This change addresses limitations of local filtering, which could only search already-fetched courses, and ensures that users can find any course available on the backend. The implementation involves a clear separation of concerns within the data and state management layers, allowing the application to seamlessly switch between browsing a locally-persisted course list and displaying dynamic, API-driven search results without compromising the integrity of the local database. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully implements a server-side search for courses, replacing the previous local filtering mechanism. The changes are well-structured, introducing a dedicated CourseSearch provider to manage search state and cleanly separating it from the main CourseList provider which now handles both browsing (from a database stream) and search results (from an in-memory list). The API and repository layers are correctly updated to support non-persistent search queries. My main feedback is on the UI implementation, where the debouncing logic for the search input unintentionally affects the responsiveness of client-side filtering for lessons. I've suggested a change to address this for a better user experience.
622bb7e to
8a45116
Compare
2c24df0 to
a6b2077
Compare
8a45116 to
25817d6
Compare
a6b2077 to
740003d
Compare
25817d6 to
fce3a42
Compare
* Transition from local filtering to direct server-side search for comprehensive results * Separate search results from the main list to keep the experience clean * Add protection against accidental duplicate requests when scrolling or typing fast * Optimize the study screen search to properly handle search clearing and new queries
740003d to
798e969
Compare
…ation support and remove client-side filtering