refactor(course): Isolate lesson content types through router orchestration#53
refactor(course): Isolate lesson content types through router orchestration#53syed-tp wants to merge 2 commits intoref/dio-singletonfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the lesson detail implementation into a domain-partitioned model, replacing the generic LessonDetailScreen with specialized screens like PdfLessonDetailScreen and updating the router to handle orchestration. Key feedback includes restoring missing navigation callbacks in the router to prevent functional regressions, improving null safety when handling PDF content URLs, and updating the specification documentation to reflect the architectural changes.
openspec/changes/lesson-detail-refactor/specs/lesson-pdf-playback/spec.md
Outdated
Show resolved
Hide resolved
syed-tp
changed the base branch from
dto-hierarchy-flattening
to
ref/dio-singleton
syed-tp
force-pushed
the
ref/lesson-detail
branch
4 times, most recently
from
47b16c7 to
eade155
Compare
…estration and specialized content screens
syed-tp
force-pushed
the
ref/lesson-detail
branch
from
eade155 to
18ff4b4
Compare
1 participant
LessonDetailScreento untangle overlapping PDF and Video renderer logic. Delegate content switching to the router to eliminate redundant UI layers and simplify the stack. Standardize screen filenames ensuring naming consistency.