Skip to content

refactor: isolate SDK Realm configuration from host application#134

Merged
Balamurugan-Testpress merged 2 commits intomainfrom
refactor_realm-config-isolation
Mar 17, 2026
Merged

refactor: isolate SDK Realm configuration from host application#134
Balamurugan-Testpress merged 2 commits intomainfrom
refactor_realm-config-isolation

Conversation

@Balamurugan-Testpress
Copy link
Copy Markdown
Contributor

  • The SDK previously relied on Realm’s global default configuration, which could affect Realm usage in the host application.
  • This happened because the SDK did not restrict the Realm schema and used the shared configuration.
  • This is fixed by introducing a dedicated SDK Realm configuration with restricted objectTypes and ensuring the SDK always opens Realm using that configuration.

References:
realm/realm-swift#2807
https://stackoverflow.com/questions/30492098/multiple-realms-with-multiple-data-models

- The SDK previously relied on Realm’s global default configuration, which could affect Realm usage in the host application.
- This happened because the SDK did not restrict the Realm schema and used the shared configuration.
- This is fixed by introducing a dedicated SDK Realm configuration with restricted `objectTypes` and ensuring the SDK always opens Realm using that configuration.

References:
realm/realm-swift#2807
https://stackoverflow.com/questions/30492098/multiple-realms-with-multiple-data-models
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the SDK's usage of Realm could interfere with a host application also using Realm. By introducing a dedicated and isolated Realm configuration for the SDK, it ensures that the SDK operates within its own defined schema and file, preventing unintended interactions and improving robustness for applications integrating the SDK.

Highlights

  • SDK Realm Configuration Isolation: The SDK's Realm configuration is now isolated from the host application's Realm configuration to prevent potential conflicts and ensure independent operation.
  • Dedicated Realm Configuration: A dedicated Realm.Configuration (TPStreamsSDK.realmConfig) has been introduced for the SDK, specifying its own schema (objectTypes: [LocalOfflineAsset.self]) and file path.
  • Explicit Realm Initialization: All Realm instances within the SDK now explicitly use TPStreamsSDK.realmConfig instead of relying on the global default configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Source/Database/ObjectManager.swift
    • Updated the Realm initializer to use TPStreamsSDK.realmConfig.
  • Source/TPStreamsSDK.swift
    • Added a new static property realmConfig to store the SDK's specific Realm configuration.
    • Refactored the initializeDatabase method to utilize the new buildRealmConfig function.
    • Introduced buildRealmConfig to create and return a Realm.Configuration with a specific file path and objectTypes (specifically LocalOfflineAsset.self).
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively isolates the SDK's Realm configuration, preventing potential conflicts with a host application. This is a valuable improvement. However, the current implementation introduces some significant risks. The use of try! for Realm initialization could lead to crashes in the host application, which is a critical issue for an SDK. Furthermore, the changes break testability by hardcoding the database configuration, which will cause problems for the existing test suite. I've provided specific suggestions to address these points and improve the overall robustness of the code.

@Balamurugan-Testpress Balamurugan-Testpress merged commit 66bc24d into main Mar 17, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants