refactor: isolate SDK Realm configuration from host application#134
refactor: isolate SDK Realm configuration from host application#134Balamurugan-Testpress merged 2 commits intomainfrom
Conversation
- The SDK previously relied on Realm’s global default configuration, which could affect Realm usage in the host application. - This happened because the SDK did not restrict the Realm schema and used the shared configuration. - This is fixed by introducing a dedicated SDK Realm configuration with restricted `objectTypes` and ensuring the SDK always opens Realm using that configuration. References: realm/realm-swift#2807 https://stackoverflow.com/questions/30492098/multiple-realms-with-multiple-data-models
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the SDK's usage of Realm could interfere with a host application also using Realm. By introducing a dedicated and isolated Realm configuration for the SDK, it ensures that the SDK operates within its own defined schema and file, preventing unintended interactions and improving robustness for applications integrating the SDK. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively isolates the SDK's Realm configuration, preventing potential conflicts with a host application. This is a valuable improvement. However, the current implementation introduces some significant risks. The use of try! for Realm initialization could lead to crashes in the host application, which is a critical issue for an SDK. Furthermore, the changes break testability by hardcoding the database configuration, which will cause problems for the existing test suite. I've provided specific suggestions to address these points and improve the overall robustness of the code.
objectTypesand ensuring the SDK always opens Realm using that configuration.References:
realm/realm-swift#2807
https://stackoverflow.com/questions/30492098/multiple-realms-with-multiple-data-models