Skip to content

Artemis: Optimize Methods in Double Class for Enhanced Performance #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mike-turintech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Artemis: Optimize Methods in Double Class for Enhanced Performance #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 15 additions & 23 deletions app/src/main/java/control/Double.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ public class Double {
public static int sumSquare(int n) {
int sum = 0;
for (int i = 0; i < n; i++) {
for (int j = 0; j < n; j++) {
if (i == j) {
sum = sum + i * j;
}
}
sum += i * i; // Optimized calculation
}
return sum;
}
Expand All @@ -27,10 +23,8 @@ public static int sumSquare(int n) {
*/
public static int sumTriangle(int n) {
int sum = 0;
for (int i = 0; i < n + 1; i++) {
for (int j = 0; j < i; j++) {
sum = sum + j;
}
for (int i = 1; i <= n; i++) {
sum += i * (i - 1) / 2; // Optimized calculation using triangular number formula
}
return sum;
}
Expand All @@ -45,20 +39,19 @@ public static int sumTriangle(int n) {
*/
public static int countPairs(int[] arr) {
int count = 0;
for (int i = 0; i < arr.length; i++) {
int nDuplicates = 0;
for (int j = 0; j < arr.length; j++) {
if (arr[i] == arr[j]) {
nDuplicates++;
}
}
if (nDuplicates == 2) {
int[] counts = new int[1001]; // Assuming values are within 0-1000, adjust if needed
for (int num : arr) {
counts[num]++;
}
for (int c : counts) {
if (c == 2) {
count++;
}
}
return count / 2;
return count / 2; // Divide by two to get number of pairs, not duplicate counts
}


/**
* Counts the number of instances where the values at the same index are equal
*
Expand All @@ -69,11 +62,10 @@ public static int countPairs(int[] arr) {
*/
public static int countDuplicates(int[] arr0, int[] arr1) {
int count = 0;
for (int i = 0; i < arr0.length; i++) {
for (int j = 0; j < arr1.length; j++) {
if (i == j && arr0[i] == arr1[j]) {
count++;
}
int minLength = Math.min(arr0.length, arr1.length); // Iterate up to the smaller length
for (int i = 0; i < minLength; i++) {
if (arr0[i] == arr1[i]) {
count++;
}
}
return count;
Expand Down