perf: optimize sql queries and database connections#31
Open
m-truscott wants to merge 1 commit intomainfrom
Open
perf: optimize sql queries and database connections#31m-truscott wants to merge 1 commit intomainfrom
m-truscott wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor and optimize SQL queries in the
SqlQueryclass to prevent SQL injection vulnerabilities, ensure database connections are closed properly, and improve overall query execution performance.Changes
contextlib.closingfor allsqlite3.connectcalls to ensure safe connection closuresalbum_existsto use parameterized queries andSELECT 1withfetchone()to avoid fetching full rows and prevent SQL injectionjoin_albumsto useLEFT JOINs instead of nested subqueries for improved execution timetop_invoicesto apply theLIMIT 10clause in SQL rather than relying on Python list slicingMetrics
Validation
All validation checks passed:
uv pip install poetry && python -m poetry install— passed (runtime 1.0060s, +0.03%; memory 26316800.00B, +1.39%)python -m poetry run pytest --benchmark-skip tests/— passedpython -m poetry run pytest --benchmark-only tests/— passed