Skip to content

Migrate to sbt-typelevel#335

Merged
danicheg merged 5 commits intotypelevel:mainfrom
armanbilge:topic/sbt-typelevel
Feb 24, 2022
Merged

Migrate to sbt-typelevel#335
danicheg merged 5 commits intotypelevel:mainfrom
armanbilge:topic/sbt-typelevel

Conversation

@armanbilge
Copy link
Copy Markdown
Member

Another one needing a backport?

@armanbilge
Copy link
Copy Markdown
Member Author

Newly reported Scala 3 bincompat issues:

[error] keypool: Failed binary compatibility check against org.typelevel:keypool_3:0.4.6 (e:info.versionScheme=early-semver)! Found 6 potential problems (filtered 3)
[error]  * method destroy(scala.Function1,cats.effect.kernel.Ref,cats.MonadError)java.lang.Object in object org.typelevel.keypool.KeyPool does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.typelevel.keypool.KeyPool.destroy")
[error]  * method reap(scala.Function1,scala.concurrent.duration.FiniteDuration,cats.effect.kernel.Ref,scala.Function1,cats.effect.kernel.GenTemporal)java.lang.Object in object org.typelevel.keypool.KeyPool does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.typelevel.keypool.KeyPool.reap")
[error]  * method put(org.typelevel.keypool.KeyPool#KeyPoolConcrete,java.lang.Object,java.lang.Object,cats.effect.kernel.GenTemporal)java.lang.Object in object org.typelevel.keypool.KeyPool does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.typelevel.keypool.KeyPool.put")
[error]  * method this(scala.Function1,scala.Function1,org.typelevel.keypool.Reusable,scala.Function1,Int,cats.effect.kernel.Ref,cats.effect.kernel.GenTemporal)Unit in class org.typelevel.keypool.KeyPool#KeyPoolConcrete does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.typelevel.keypool.KeyPool#KeyPoolConcrete.this")
[error]  * method kpCreate()scala.Function1 in class org.typelevel.keypool.KeyPool#KeyPoolConcrete does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.typelevel.keypool.KeyPool#KeyPoolConcrete.kpCreate")
[error]  * method kpDestroy()scala.Function1 in class org.typelevel.keypool.KeyPool#KeyPoolConcrete does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.typelevel.keypool.KeyPool#KeyPoolConcrete.kpDestroy")

@danicheg
Copy link
Copy Markdown
Member

Outstanding. Let's merge this and see what happens. And yeah, we probably should do a backport.

@danicheg danicheg merged commit 624a9b3 into typelevel:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants