Updating tests and modifications of errors to standardize their messages#30
Closed
hippolyteblot wants to merge 37 commits intovirtual-imaging-platform:developfrom
Closed
Updating tests and modifications of errors to standardize their messages#30hippolyteblot wants to merge 37 commits intovirtual-imaging-platform:developfrom
hippolyteblot wants to merge 37 commits intovirtual-imaging-platform:developfrom
Conversation
axlbonnet
reviewed
Jun 21, 2024
.github/workflows/main.yml
Outdated
| - develop | ||
| pull_request: | ||
| branches: | ||
| - main |
Collaborator
There was a problem hiding this comment.
i would do only on develop
| # Check existence | ||
| if not self._is_defined("_input_settings"): | ||
| raise TypeError("Please provide input parameters for Session: %s" %self._session_name) | ||
| # Check content |
Collaborator
There was a problem hiding this comment.
It is removed because it is verified in _check_input_settings ?
| # Returned files (filtered information) | ||
| "outputs": [] if not infos["returnedFiles"] else [ | ||
| {"path": value} for value in infos["returnedFiles"]["output_file"] | ||
| {"path": value} for value in infos["returnedFiles"].values() |
Collaborator
There was a problem hiding this comment.
This has already been corrected, but not exactly in the same way
Can you please merge develop and call me to manage the conflict ?
| input_settings = self._get_input_settings(location) | ||
| else: | ||
| raise AttributeError("Input settings are missing") | ||
| input_settings = {} |
Collaborator
There was a problem hiding this comment.
So input_setting is optional now ?
| f"Parameter '{name}' contains some invalid character(s): {', '.join(invalid)}" | ||
| ) | ||
| # If input is a File, check file(s) existence | ||
| invalid_chars.append((name, invalid)) |
Collaborator
There was a problem hiding this comment.
better to name it invalid_chars_inputs
| ) | ||
| if param["type"] == "Boolean": | ||
| if value not in ["true", "false"]: | ||
| wrong_types.append(name) |
Collaborator
There was a problem hiding this comment.
rename wrong_type_inputs
| # Case: VIP path | ||
| if str(input).startswith(self._SERVER_PATH_PREFIX): # PurePath.is_relative_to() is unavailable for Python <3.9 | ||
| if self._is_defined('_vip_input_dir'): | ||
| if str(input).startswith(self._SERVER_PATH_PREFIX) and len(str(input)) > 0: # PurePath.is_relative_to() is unavailable for Python <3.9 |
Collaborator
There was a problem hiding this comment.
i guesse input can be empy at this point ? it is not verified yet ?
Member
Author
|
Replaced by PR #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.