installation via chroot guide#177
Conversation
0d34825 to
9b15d52
Compare
|
I've worked out the issues I was having before,
If the team is satisfied with the quality of the guide, it's ready to be merged. |
|
This is moving in a good direction :) I'm sure I'll have more nitpicks when I have time to review again. I just want to keep this down to basics. I'm fine with adding information elsewhere and referencing, but I'd like to keep this in the spirit of bootstrapping a system. It's going well so far. I think just using |
db56847 to
f577a45
Compare
That's reasonable, I've made that change. I read through the guide again and made some small edits, mostly aiming at consistency in punctuation and style, also removing filler words. I changed my "NB"s to "Note:" and put them in block quotes, copying the style of config/networking/iwd.md |
|
Cool. I'm really busy but will do another review ASAP |
|
@ericonr yes, my intention was to get this merged, then move incrementally from there. I certainly don't have time so any help would be appreciated :) |
|
197426c to
5cb1e4a
Compare
|
Just realized it would be great if you included how to set up services when the system isn't booted. Something like:
Then refer them to this page https://docs.voidlinux.org/config/services/managing.html#enabling-services |
ericonr
left a comment
There was a problem hiding this comment.
This one was a bit more nit-picky. It's looking pretty good!
| single SATA/IDE/USB disk. Each step may be modified to create less typical | ||
| setups, such as [full disk encryption](./fde.md). | ||
|
|
||
| Void provides two options for bootstrapping the new installation. The **XBPS |
There was a problem hiding this comment.
Bootstrapping refers to the process of compiling your whole system (or most of it). In our case, I'd write for " for creating the new installation" or similar.
There was a problem hiding this comment.
how about "for installing the base distribution"? I've used that wording elsewhere in this guide
There was a problem hiding this comment.
distribution -> system, perhaps?
There was a problem hiding this comment.
"Bootstrapping" does not imply compilation to me; it is simply the process of getting something running from nothing. In xbps-source, the bootstrap command does compile all of the base packages, but there is also binary-bootstrap to bootstrap a chroot from prebuilt binary packages.
If there is still resistance to "bootstrapping", I do agree that "for installing the base system" is an appropriate alternative.
There was a problem hiding this comment.
I don't think "bootstrapping" is incorrect here, but I do agree that it could cause confusion with compiling the whole thing from source. I'm good with "installing the base system"
There was a problem hiding this comment.
Well, I think I had been in a bootstrapping from zero mood when I made that comment, but after re-reading I feel like bootstrapping fits just fine.
c166b25 to
94789be
Compare
|
I found a typo in this line: |
|
thank you @glats ! |
src/installation/guides/chroot.md
Outdated
| After booting into your Void installation for the first time, be sure to do a | ||
| system [update](../../xbps/updating.md). |
There was a problem hiding this comment.
Final nitpick, I guess: "perform a system update". I'm excited to merge this, thanks a lot for the effort!
There was a problem hiding this comment.
I copied that line out of installation/live-images/guide.md. I prefer "perform a system update" as well. Can I change both?
There was a problem hiding this comment.
this is ready to go
…uide installation/live-images/guide.md: change wording to match that used in chroot.md
|
Well, CI failed because OpenBSD websites are down. Didn't expect this one. |
|
ah, that makes sense. I couldn't make sense of the error, but I figured out it wasn't my fault since other recent PRs were failing too. Once it's back up, do I need to do something to trigger ci to run again? |
|
i've just manually re-run CI for this, and it's now passing. :-) |
|
I can make a final review over the weekend and merge it. If @flexibeast can do it earlier, I am fine with it being merged. Thanks!! |
|
There are still some formatting issues (e.g. the link to @jeffayle: Thank you for all the time and work you've put into this! i really appreciate it. :-) |
This guide is not quite complete. I would like feedback on what is and isn't included, and whether any steps are confusing (or wrong).
There are three areas in particular that I am unsure of (they are currently marked in the text with TODO)
grub-install. The guides in the wiki include a number of switches that are either default or automatically configured. are any of these automatic configurations liable to break, should the switches be included in the instructions?