New package: turnstile-0.1.8#44676
Merged
classabbyamp merged 5 commits intovoid-linux:masterfrom Mar 22, 2024
Merged
Conversation
Contributor
|
This is interesting. Besides creating /run/user/nnn, can the runit backend be used to supervise user services, like pipewire or running mbsync? I'd be happy to help with test. |
Member
Author
|
yes. i have it mostly working but i haven't pushed the changes yet. note that the commit i linked does not work, I needed to do a fair amount of refactoring to get it to work. need to do other things for the moment, will probably get back to it next week |
classabbyamp
force-pushed
the
new/turnstile
branch
2 times, most recently
from
4ad4f22 to
572da3b
Compare
Member
Author
|
current state: what works:
what doesn't work:
what's untested:
what's blocking:
some example services (pipewire, syncthing atm): https://github.com/classabbyamp/dotfiles/tree/master/dot_config/service |
classabbyamp
changed the title
classabbyamp
force-pushed
the
new/turnstile
branch
from
572da3b to
80ad9ac
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
at this point I would just wait, it's not fully working yet. it could be because elogind is running and conflicting with it, or seatd is not running perhaps |
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
if you'd like, the debug logs would be helpful. set |
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
if i had to guess it's that greetd is missing a line about turnstile in its pam config. logging in via a tty successfully would trigger the system-login pam entry and would start the runit backend. then, when the logging in via greetd after that, runit is already running so it works fine. |
This comment was marked as resolved.
This comment was marked as resolved.
classabbyamp
force-pushed
the
new/turnstile
branch
from
80ad9ac to
cb26b06
Compare
classabbyamp
changed the title
|
Sorry for all the added noise. 0.1.6 fixed the issue for me. |
classabbyamp
force-pushed
the
new/turnstile
branch
from
cb26b06 to
55f2281
Compare
classabbyamp
force-pushed
the
new/turnstile
branch
from
55f2281 to
4a28baf
Compare
classabbyamp
force-pushed
the
new/turnstile
branch
from
4a28baf to
34a9c61
Compare
classabbyamp
changed the title
Member
Author
|
still todo:
|
Contributor
|
does it mean now we don't need to build off master and user services do exit? |
Member
Author
|
maybe |
classabbyamp
force-pushed
the
new/turnstile
branch
from
34a9c61 to
273e0eb
Compare
classabbyamp
force-pushed
the
new/turnstile
branch
from
76b8150 to
bf6e09f
Compare
Contributor
|
works for me, thanks. |
classabbyamp
force-pushed
the
new/turnstile
branch
from
bf6e09f to
40820c3
Compare
Contributor
|
Within my setup, and using greetd, turnstile for user still persists, instead of killing the user's services upon logout: Upon logging out and in as another user, I still see my services in htop. |
Contributor
|
indeed (i missed the msg above) greetd also needs a modification to pam file. |
Member
Author
|
what modification? it includes system-local-login: which includes system-login which already supports turnstile, if you built pam-base from this branch: |
Member
Author
can you set |
Contributor
|
I did build pam from this branch, and notice this does not happen with login/agetty. log |
Contributor
|
btw, turnstile also tracks a session for the _greeter user, not sure if this is related. the river run being a script that sets some variables and runs river. |
Member
Author
not related, and intended i think |
Contributor
sounds reasonable. (this only happens if I do not login into the tty using greetd, in which case the |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
classabbyamp
force-pushed
the
new/turnstile
branch
2 times, most recently
from
4c5143c to
c33cd89
Compare
Contributor
|
any chance this can be merged, or at least the change to pam-base? |
Member
Author
|
waiting on q66 to merge the runit backend, I don't want to deal with some kind of bad update later if he wants changes with it in the PR |
Contributor
|
i understand you'd want to wait for turnstile itself, but why not merge at least the pam-base change? |
classabbyamp
force-pushed
the
new/turnstile
branch
from
c33cd89 to
d7bee88
Compare
classabbyamp
force-pushed
the
new/turnstile
branch
from
d7bee88 to
f62fa6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP while i create the runit backend upstream (mostly done)
Testing the changes
New package