Skip to content

fix: fix vectordb#164

Merged
zhoujh01 merged 1 commit intomainfrom
fix_vectordb
Feb 13, 2026
Merged

fix: fix vectordb#164
zhoujh01 merged 1 commit intomainfrom
fix_vectordb

Conversation

@zhoujh01
Copy link
Collaborator

@zhoujh01 zhoujh01 commented Feb 13, 2026

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Summary:
    This commit enhances the robustness of the fetch_cands_data logic in openviking/storage/vectordb/collection/local_collection.py.

Key Changes:

  1. Data Consistency: It fixes a potential issue where data lists could become misaligned. The code now correctly identifies indices of valid (non-None)
    candidates and applies this filter synchronously to cands_list, pk_list (primary keys), and scores_list. Previously, None values might have been removed from
    the candidates list without updating the corresponding parallel lists.
  2. Enhanced Logging: It adds warning logs when invalid (None) candidate data is encountered, which helps in debugging data integrity issues.

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@zhoujh01 zhoujh01 merged commit f1f6b9b into main Feb 13, 2026
5 checks passed
@zhoujh01 zhoujh01 deleted the fix_vectordb branch February 13, 2026 11:58
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants