fix(parser): hash & shorten filenames that exceed filesystem limit#205
Merged
MaojiaSheng merged 1 commit intovolcengine:mainfrom Feb 18, 2026
Merged
Conversation
9bb4ed9 to
b2637b9
Compare
When parsing documents with long titles or section headings (e.g., shell scripts whose comments are treated as markdown headings), the generated filenames could exceed the OS 255-byte limit, causing 'file name too long' errors. Fix: - _sanitize_for_path: append SHA-256 hash suffix when truncating, ensuring uniqueness across different long titles that share a common prefix - _generate_merged_filename: apply same hash-based truncation - _generate_filename (downloader): apply same pattern - VikingFS._uri_to_path: add safety net that shortens any path component exceeding 255 bytes, guaranteeing no filesystem error regardless of which parser produced the URI Fixes volcengine#171
b2637b9 to
2e43268
Compare
MaojiaSheng
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix "file name too long" error when adding resources with long titles or section headings (e.g., shell scripts whose
#comments are treated as markdown headings).When filenames exceed the OS limit, they are now truncated with a SHA-256 hash suffix to preserve uniqueness.
Type of Change
Testing
tests/parse/test_filename_safety.py— 23 new tests)Related Issues
Checklist