Skip to content

fix: target directories retrieve#227

Merged
MaojiaSheng merged 4 commits intovolcengine:mainfrom
mildred522:fix/target-directories-retrieve
Feb 20, 2026
Merged

fix: target directories retrieve#227
MaojiaSheng merged 4 commits intovolcengine:mainfrom
mildred522:fix/target-directories-retrieve

Conversation

@mildred522
Copy link
Contributor

Description

Fixes retrieval ignoring target_directories: when find/search passes target_uri/target_directories, the retriever now uses those directories as roots
and adds a URI prefix filter to prevent out-of-scope results. Adds a unit test to cover the expected semantics.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Honor target_directories in HierarchicalRetriever by using them as root_uris
  • Add a URI prefix filter when target_directories is provided
  • Add a unit test covering target_directories semantics

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

@mildred522 mildred522 changed the title Fix/target directories retrieve fix: target directories retrieve Feb 19, 2026
@mildred522 mildred522 force-pushed the fix/target-directories-retrieve branch from ca8dddd to 6d739b9 Compare February 19, 2026 15:18
@MaojiaSheng MaojiaSheng merged commit ecc1ada into volcengine:main Feb 20, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants